Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[db] ResetSnapshots() performance improvement #4153

Merged
merged 6 commits into from
Mar 5, 2024

Conversation

millken
Copy link
Contributor

@millken millken commented Feb 28, 2024

Description

Reduced the computation of map keyhash, reduced keyCacheValue memory allocation, Mintblock time dropped by half, this PR has been tested on nightly

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • Code refactor or improvement
  • [] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
  • [] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • make test
  • [] fullsync
  • [] Other test (please specify)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [] My code follows the style guidelines of this project
  • [] I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • [] Any dependent changes have been merged and published in downstream modules

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 76.40%. Comparing base (e1f0636) to head (9bed39b).
Report is 179 commits behind head on master.

Files Patch % Lines
db/batch/batch_impl.go 81.81% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4153      +/-   ##
==========================================
+ Coverage   75.38%   76.40%   +1.02%     
==========================================
  Files         303      339      +36     
  Lines       25923    28890    +2967     
==========================================
+ Hits        19541    22073    +2532     
- Misses       5360     5716     +356     
- Partials     1022     1101      +79     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@CoderZhi CoderZhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any benchmark test?

db/batch/batch_impl.go Show resolved Hide resolved
@millken
Copy link
Contributor Author

millken commented Feb 28, 2024

any benchmark test?

benchmark added

db/batch/batch_impl.go Outdated Show resolved Hide resolved

func (kv *kvCacheValue) reset() {
([]int)(*kv)[0] = 0
*kv = (*kv)[0:1]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[:1]

db/batch/kv_cache.go Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Mar 5, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@millken millken merged commit 9002bad into iotexproject:master Mar 5, 2024
4 of 5 checks passed
@millken millken deleted the kvcache_improvement branch March 5, 2024 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants