[db] Remove duplicate keys when WriteBatch #4155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
envestcc
requested review from
CoderZhi,
dustinxie and
Liuhaai
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4155 +/- ##
==========================================
+ Coverage 75.38% 76.39% +1.01%
==========================================
Files 303 340 +37
Lines 25923 28971 +3048
==========================================
+ Hits 19541 22132 +2591
- Misses 5360 5732 +372
- Partials 1022 1107 +85 ☔ View full report in Codecov by Sentry. |
CoderZhi
reviewed
Feb 29, 2024
db/db_bolt.go
Outdated
| } | ||
| } | ||
| boltdbMtc.WithLabelValues(b.path, "entrySize").Set(float64(kvsb.Size())) | ||
| boltdbMtc.WithLabelValues(b.path, "entryMapSize").Set(float64(len(entryMap))) |
| if e != nil { | ||
| return e | ||
| } | ||
| k := doubleKey{ns: write.Namespace(), key: string(write.Key())} |
There was a problem hiding this comment.
only handle writeType batch.Put and batch.Delete
CoderZhi
approved these changes
Feb 29, 2024
millken
approved these changes
Mar 5, 2024
Liuhaai
reviewed
Mar 5, 2024
db/db_bolt.go
Outdated
| if e != nil { | ||
| return e | ||
| } | ||
| // though range entryMap is random, but it doesn't matter which key is processed first |
There was a problem hiding this comment.
will the random sequence cause the nondeterministic md5 value of Snapshot file? For example, will the binary file(*.db) be same between bucket.Put(A,{}) -> bucket.Put(B,{}) and bucket.Put(B,{}) -> bucket.Put(A,{})?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the scenario of 500 TPS, the
CommitBlocktime is relatively long (2~3s), and most of the time is spent on db.WriteBatch, requiring optimization.After testing and analysis, there are many duplicate redundant operations in WriteBatch (2w operations for only 6~8k keys). Therefore, before executing the write operation of db, we deduplicate the keys, keeping only the last operation for each key.
Ultimately, the
CommitBlocktime was optimized to around 200ms.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: