Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[e2etest] Fix flaky test #4165

Merged
merged 2 commits into from
Mar 6, 2024
Merged

[e2etest] Fix flaky test #4165

merged 2 commits into from
Mar 6, 2024

Conversation

envestcc
Copy link
Member

@envestcc envestcc commented Mar 5, 2024

Description

Fixes #4162

Type of change

Please delete options that are not relevant.

  • Code refactor or improvement

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • make test

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [] My code follows the style guidelines of this project
  • [] I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • [] Any dependent changes have been merged and published in downstream modules

@envestcc envestcc requested a review from a team as a code owner March 5, 2024 11:03
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.38%. Comparing base (e1f0636) to head (8008877).
Report is 184 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4165      +/-   ##
==========================================
+ Coverage   75.38%   76.38%   +1.00%     
==========================================
  Files         303      340      +37     
  Lines       25923    28937    +3014     
==========================================
+ Hits        19541    22103    +2562     
- Misses       5360     5729     +369     
- Partials     1022     1105      +83     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Mar 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
4.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@envestcc envestcc merged commit 9cb3441 into iotexproject:master Mar 6, 2024
3 of 5 checks passed
@envestcc envestcc deleted the pr-4162 branch March 6, 2024 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix flaky test in nodeinfo_test.go
3 participants