Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deterministic action pick order #4175

Merged
merged 3 commits into from
Mar 11, 2024
Merged

Conversation

CoderZhi
Copy link
Collaborator

@CoderZhi CoderZhi commented Mar 9, 2024

Actions are picked from action pool by gas price. However, if two actions from different accounts are of the same gas price, the order of these two actions is random. Having a deterministic order is important to unit tests which may rely on the order.

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Code refactor or improvement
  • [] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
  • [] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [] make test
  • [] fullsync
  • [] Other test (please specify)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [] My code follows the style guidelines of this project
  • [] I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • [] Any dependent changes have been merged and published in downstream modules

Copy link

codecov bot commented Mar 9, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 76.16%. Comparing base (e1f0636) to head (533284f).
Report is 197 commits behind head on master.

Files Patch % Lines
actpool/actioniterator/actioniterator.go 66.66% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4175      +/-   ##
==========================================
+ Coverage   75.38%   76.16%   +0.78%     
==========================================
  Files         303      340      +37     
  Lines       25923    29063    +3140     
==========================================
+ Hits        19541    22137    +2596     
- Misses       5360     5827     +467     
- Partials     1022     1099      +77     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Mar 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dustinxie dustinxie merged commit d4cfc8e into master Mar 11, 2024
3 of 5 checks passed
@dustinxie dustinxie deleted the deterministric_action_pick branch March 11, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants