test: add unit test for module blockdao #4182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saitofun
requested review from
CoderZhi,
dustinxie,
Liuhaai and
a team
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4182 +/- ##
==========================================
+ Coverage 75.38% 76.55% +1.17%
==========================================
Files 303 340 +37
Lines 25923 29165 +3242
==========================================
+ Hits 19541 22327 +2786
- Misses 5360 5734 +374
- Partials 1022 1104 +82 ☔ View full report in Codecov by Sentry. |
CoderZhi
approved these changes
Mar 14, 2024
dustinxie
reviewed
Mar 14, 2024
blockchain/blockdao/blockdao_test.go
Outdated
| // p := gomonkey.NewPatches() | ||
| // defer p.Reset() | ||
|
|
||
| // p.ApplyMethodReturn(&BlockIndexerChecker{}, "CheckIndexer", nil) |
dustinxie
reviewed
Mar 14, 2024
blockchain/blockdao/blockdao_test.go
Outdated
| p.ApplyPrivateMethod(&blockDAO{}, "checkIndexers", func(*blockDAO, context.Context) error { return nil }) | ||
|
|
||
| err := blockdao.Start(context.Background()) | ||
| r.Nil(err) |
There was a problem hiding this comment.
let's use r.NoError() for consistency
dustinxie
reviewed
Mar 14, 2024
blockchain/blockdao/blockdao_test.go
Outdated
| mockblockdao.EXPECT().GetBlockByHeight(gomock.Any()).Return(&block.Block{}, nil).Times(1) | ||
|
|
||
| err := blockdao.checkIndexers(ctx) | ||
| r.Nil(err) |
There was a problem hiding this comment.
let's use r.NoError() for consistency
dustinxie
approved these changes
Mar 15, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add unit test for module blockchain/blockdao
Fixes #4121
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: