Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix TestHash genesis hash not match mainnet genesis hash #4190

Merged
merged 3 commits into from
Apr 1, 2024
Merged

fix TestHash genesis hash not match mainnet genesis hash #4190

merged 3 commits into from
Apr 1, 2024

Conversation

millken
Copy link
Contributor

@millken millken commented Mar 15, 2024

Description

update mainnet hardcode genesis config, make TestHash genesis hash equal mainnet genesis hash

Fixes #4189

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Code refactor or improvement
  • [] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
  • [] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • make test
  • [] fullsync
  • [] Other test (please specify)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [] My code follows the style guidelines of this project
  • [] I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • [] Any dependent changes have been merged and published in downstream modules

@millken
Copy link
Contributor Author

millken commented Mar 15, 2024

After modifying the genesis default, many tests failed, I am fixing it.
Maybe we shouldn't modify it.

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.77%. Comparing base (e1f0636) to head (a4aa161).
Report is 219 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4190      +/-   ##
==========================================
+ Coverage   75.38%   76.77%   +1.39%     
==========================================
  Files         303      340      +37     
  Lines       25923    29269    +3346     
==========================================
+ Hits        19541    22472    +2931     
- Misses       5360     5694     +334     
- Partials     1022     1103      +81     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Apr 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@millken millken merged commit 6c5ecae into iotexproject:master Apr 1, 2024
4 of 5 checks passed
@millken millken deleted the issue4189 branch April 1, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

verify mainnet's genesis hash
3 participants