[evm] gate the generation of suicide transaction log

[dustinxie]

Description

To ensure data consistency, generate the missing log after the hard-fork. A separate patch file will be created later to provide missing logs before the hard-fork.
// TODO: remove this gating once the hard-fork has passed
Fixes #(issue)

Type of change

Please delete options that are not relevant.

• [] Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• [] Code refactor or improvement
• [] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
• [] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• make test
• [] fullsync
• [] Other test (please specify)

Test Configuration:

• Firmware version:
• Hardware:
• Toolchain:
• SDK:

Checklist:

• [] My code follows the style guidelines of this project
• [] I have performed a self-review of my code
• [] I have commented my code, particularly in hard-to-understand areas
• [] I have made corresponding changes to the documentation
• [] My changes generate no new warnings
• [] I have added tests that prove my fix is effective or that my feature works
• [] New and existing unit tests pass locally with my changes
• [] Any dependent changes have been merged and published in downstream modules

[codecov]

Codecov Report

Attention: Patch coverage is 90.90909% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 76.77%. Comparing base (e1f0636) to head (b482680).
Report is 213 commits behind head on master.

Files	Patch %	Lines
action/protocol/execution/evm/evmstatedbadapter.go	90.90%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4198      +/-   ##
==========================================
+ Coverage   75.38%   76.77%   +1.39%     
==========================================
  Files         303      340      +37     
  Lines       25923    29260    +3337     
==========================================
+ Hits        19541    22465    +2924     
- Misses       5360     5691     +331     
- Partials     1022     1104      +82     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[envestcc]

stateDB.suicideTxLogMismatchPanic must be true here

[envestcc]

does it would cause testnet to rollback?

[dustinxie]

the flag can be removed after hard-fork, so would just leave it as is.
no, it won't cause testnet to rollback, txLog does not affect consensus

[sonarcloud]

Quality Gate failed

Failed conditions
8.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud