[genesis] add Upernavik block height #4206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4206 +/- ##
==========================================
+ Coverage 75.38% 76.76% +1.38%
==========================================
Files 303 340 +37
Lines 25923 29269 +3346
==========================================
+ Hits 19541 22468 +2927
- Misses 5360 5696 +336
- Partials 1022 1105 +83 ☔ View full report in Codecov by Sentry. |
dustinxie
commented
Mar 27, 2024
| @@ -258,6 +259,9 @@ type ( | |||
| // 2. generate transaction log for Suicide() call in EVM | |||
| // 3. raise block gas limit to 50M | |||
| TsunamiBlockHeight uint64 `yaml:"tsunamiHeight"` | |||
| // UpernavikBlockHeight is the start height to | |||
| // 1. enable Cancun EVM | |||
| UpernavikBlockHeight uint64 `yaml:"upernavikHeight"` | |||
There was a problem hiding this comment.
it is an island/strait in Greenland
There was a problem hiding this comment.
A tsunami sent us to Upernavik 😄
millken
reviewed
Mar 28, 2024
| @@ -76,6 +76,7 @@ func defaultConfig() Genesis { | |||
| RedseaBlockHeight: 26704441, | |||
| SumatraBlockHeight: 28516681, | |||
| TsunamiBlockHeight: 29275561, | |||
| UpernavikBlockHeight: 39275561, | |||
There was a problem hiding this comment.
the hardfork height will be reset later, right?
There was a problem hiding this comment.
right, we set to a very far date, before release, will change to the planned date
envestcc
approved these changes
Mar 28, 2024
millken
approved these changes
Mar 28, 2024
2 tasks
Liuhaai
approved these changes
Mar 28, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
adding the height for 1.15
Fixes #(issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: