Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api] add unit test for coreService #4213

Merged
merged 12 commits into from
Apr 10, 2024
Merged

[api] add unit test for coreService #4213

merged 12 commits into from
Apr 10, 2024

Conversation

hunshenshi
Copy link
Contributor

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Base #4212

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Code refactor or improvement
  • [] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
  • [] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [] make test
  • [] fullsync
  • [] Other test (please specify)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [] My code follows the style guidelines of this project
  • [] I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • [] Any dependent changes have been merged and published in downstream modules

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.08%. Comparing base (d716bb9) to head (801d5a4).
Report is 19 commits behind head on master.

❗ Current head 801d5a4 differs from pull request most recent head c52bb36. Consider uploading reports for the commit c52bb36 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4213      +/-   ##
==========================================
+ Coverage   76.51%   77.08%   +0.57%     
==========================================
  Files         340      340              
  Lines       29273    29256      -17     
==========================================
+ Hits        22397    22553     +156     
+ Misses       5761     5615     -146     
+ Partials     1115     1088      -27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Apr 10, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
15.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@hunshenshi hunshenshi merged commit b4f0ec3 into master Apr 10, 2024
2 of 3 checks passed
@hunshenshi hunshenshi deleted the core-test branch April 10, 2024 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants