[blockdao] Optimize derialization when retrieving receipts #4221
Conversation
Liuhaai
requested review from
CoderZhi,
dustinxie,
millken,
envestcc and
a team
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4221 +/- ##
==========================================
+ Coverage 75.38% 76.73% +1.35%
==========================================
Files 303 340 +37
Lines 25923 29293 +3370
==========================================
+ Hits 19541 22478 +2937
- Misses 5360 5710 +350
- Partials 1022 1105 +83 ☔ View full report in Codecov by Sentry. |
| // // verify merkle root can match after deserialize | ||
| // if err := blk.VerifyTxRoot(); err != nil { | ||
| // return nil, err | ||
| // } |
There was a problem hiding this comment.
uncomment this?
this is not the bottleneck for now, also it how has a cache for blocks now
| @@ -172,21 +171,71 @@ func (fd *fileDAOv2) highestBlockOfStoreTip() uint64 { | |||
| return fd.header.Start + fd.blkStore.Size()*fd.header.BlockStoreSize - 1 | |||
| } | |||
|
|
|||
| func (fd *fileDAOv2) getBlockStore(height uint64) (*block.Store, error) { | |||
| func (fd *fileDAOv2) getBlock(height uint64) (*block.Block, error) { | |||
There was a problem hiding this comment.
adding block/receipt cache is good idea to improve read performance
can keep getBlockStore() to get even better performance
can you incorporate the changes under /filedao in f1bc955 into this PR?
There was a problem hiding this comment.
check the top commit of origin/v2dao branch
|
Description
getTransactionReceiptis monitored to consume lots of cpu resources when serving for web3 requests.Block and Receipt are deserialized and cached separtedly to reduce duplicate computing
Fixes #(issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: