[action] add EvmTransaction to represent actions that run in EVM #4227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustinxie
requested review from
CoderZhi,
Liuhaai,
envestcc,
millken and
a team
as code owners
envestcc
reviewed
Apr 17, 2024
envestcc
reviewed
Apr 17, 2024
dustinxie
changed the title
dustinxie
added a commit
that referenced
this pull request
Apr 17, 2024
dustinxie
added a commit
that referenced
this pull request
Apr 18, 2024
envestcc
reviewed
Apr 19, 2024
envestcc
approved these changes
Apr 19, 2024
millken
reviewed
Apr 19, 2024
| if dest := execution.Contract(); dest != action.EmptyAddress { | ||
| contract, err := address.FromString(execution.Contract()) | ||
| if err != nil { | ||
| return nil, errors.Wrapf(err, "failed to decode contract address %s", dest) |
There was a problem hiding this comment.
new code panic instead of return error, no problem?
millken
approved these changes
Apr 19, 2024
|
|
It is hard to see the value of representing Execution as EvmTransaction in this PR. It would be better if we can have some description explain the purpose and plan. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #(issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: