[api] Fix wrong cache for api readState at tip height #4253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
envestcc
requested review from
CoderZhi,
dustinxie,
Liuhaai and
millken
as code owners
dustinxie
approved these changes
Apr 24, 2024
dustinxie
reviewed
Apr 24, 2024
| @@ -910,6 +910,9 @@ func (core *coreService) readState(ctx context.Context, p protocol.Protocol, hei | |||
| Method: methodName, | |||
| Args: arguments, | |||
| } | |||
| if height == "" { | |||
| key.Height = strconv.FormatUint(core.bc.TipHeight(), 10) | |||
| } | |||
Liuhaai
approved these changes
Apr 24, 2024
dustinxie
reviewed
Apr 25, 2024
| if d, ok := core.readCache.Get(key.Hash()); ok { | ||
| var h uint64 | ||
| h := tipHeight |
dustinxie
reviewed
Apr 25, 2024
dustinxie
approved these changes
Apr 25, 2024
|
CoderZhi
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The key used for interface caching is the "height" string. When an empty value is passed for the height in the query, it means to retrieve the data of the latest height. This causes the data for the latest height to still return the data for the old height.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: