[e2etest] add more test #4322
Merged
[e2etest] add more test #4322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
envestcc
requested review from
CoderZhi,
dustinxie,
Liuhaai and
a team
as code owners
Liuhaai
approved these changes
Jul 2, 2024
| @@ -470,3 +471,43 @@ func SignedMigrateStake( | |||
| } | |||
| return selp, nil | |||
| } | |||
|
|
|||
| func SignedClaimRewardLegacy( | |||
There was a problem hiding this comment.
IMO, functions in this file should be auxiliary functions in test files, since the tx builder and signing is clear already.
dustinxie
reviewed
Jul 2, 2024
| @@ -471,6 +472,78 @@ func TestBlockEpochReward(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestClaimReward(t *testing.T) { | |||
| t.Skip("") | |||
There was a problem hiding this comment.
why skip the test?
You can refer to changes in integrity_test.go, need to register a poll protocol (so that it will return a valid candidate, whose rewardAddr you can claim reward from it)
dustinxie
approved these changes
Jul 3, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add more tests on claimreward, new staking contract indexer, transfer ownership and revise endorsement
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: