libbpf-tools: Add sslsniff #4706
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Port sslsniff from tools to libbpf-tools
yunwei37
requested review from
drzaeus77,
goldshtn,
yonghong-song,
4ast,
brendangregg and
davemarchevsky
as code owners
chenhengqi
reviewed
Aug 28, 2023
| return true; | ||
| } | ||
|
|
||
| SEC("uprobe/do_handshake") |
There was a problem hiding this comment.
There is another uprobe/do_handshake section below, this one looks incorrect.
| {}, | ||
| }; | ||
|
|
||
| static bool verbose = false; |
There was a problem hiding this comment.
Make verbose a member of struct env ?
| }) | ||
|
|
||
| struct { | ||
| __uint(type, BPF_MAP_TYPE_PERCPU_ARRAY); |
There was a problem hiding this comment.
We have a compat layer in compat.bpf.h which abstracts this percpu array out, see mountsnoop for example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR aims to transition the
sslsnifftool from the tools directory to the libbpf-tools collection.Reference:
sslsniffin bcc:Testing:
Setup:
sslsniffby running:Output:
Upon running the curl command,
sslsniffis expected to display the following output:READ/RECV 0.132786160 curl 47458 1256 ----- DATA ----- <!doctype html> <html> <head> <title>Example Domain</title> <meta charset="utf-8" /> <meta http-equiv="Content-type" content="text/html; charset=utf-8" /> <meta name="viewport" content="width=device-width, initial-scale=1" /> <style type="text/css"> body { background-color: #f0f0f2; margin: 0; padding: 0; font-family: -apple-system, system-ui, BlinkMacSystemFont, "Segoe UI", "Open Sans", "Helvetica Neue", Helvetica, Arial, sans-serif; } div { width: 600px; margin: 5em auto; padding: 2em; background-color: #fdfdff; border-radius: 0.5em; box-shadow: 2px 3px 7px 2px rgba(0,0,0,0.02); } a:link, a:visited { color: #38488f; text-decoration: none; } @media (max-width: 700px) { div { margin: 0 auto; width: auto; } } </style> </head> <body> <div> <h1>Example Domain</h1> <p>This domain is for use in illustrative examples in documents. You may use this domain in literature without prior coordination or asking for permission.</p> <p><a href="https://www.iana.org/domains/example">More information...</a></p> </div> </body> </html> ----- END DATA -----Note: The displayed HTML content might vary based on the fetched page from
example.com.Test for latency and handshake
Test for hexdump
Further Work:
While the basic tests validate the primary functionality, comprehensive testing is needed to ensure compatibility and stability across various environments and use-cases.