Parse container id #207
Open
Parse container id #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cakemanny
reviewed
Jun 9, 2024
| needle := path.Join(podUID, containerID) | ||
| if strings.Contains(root, needle) { | ||
| // EG: /kubepods.slice/kubepods-burstable.slice/kubepods-burstable-pod40934a46_d409_4f4a_bb8b_1ec0b0436320.slice/cri-containerd-afc114c69e71f18166abd63715398d7daa763c69a6454f71157272ab0bdca783.scope | ||
| if strings.Contains(root, podUID) && strings.Contains(root, containerID) { |
There was a problem hiding this comment.
Which setup have you tested this with?
I also found that I needed to fix this when working on my PR: https://github.com/iovisor/kubectl-trace/pull/205/files#diff-3fc753f2ae105df1b499d656901818c3aae006a40a0d807d4871520a19d612a5
I found podUID contained -s in place of _s in the cgroup name.
i.e. in your example, I'd expect podUID to be "40934a46-d409-4f4a-bb8b-1ec0b0436320".
It looks like that was also mentioned in the description of #174 . (I was using kind v0.19.x on an ubuntu 22.04 VM, not sure the host matters though)
You could also feel inspired to add a unit test like I did..., but I'm not from the iovisor group, just a fellow attempting contributor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #174 .