-
Notifications
You must be signed in to change notification settings - Fork 34
Update to L5.1 #25
base: master
Are you sure you want to change the base?
Update to L5.1 #25
Conversation
Pulling latest changes from ipalaus/master
Seed only the Names, Countries and Continents tables - Updated Readme
@DODMax, can you attach the command output? I don't get any warnings about migrations:
And why |
@alexeyshockov, indeed the _table was needed because the commit I forked changed the migration classes names to add _table. Keeping both the filename and the classname without _table should also work and be backward compatible. Here is the composer warning that is raised when running dump-autoload if the migrations are installed:
|
Actually the duplicated class names warning can be fixed by removing the "src/migrations" from the autoload classmap in composer.json See 42f170c Not sure how it plays with the test but I don't think the migrations are needed outside of Laravel. |
I removed the src/migrations from vendor/ipalaus/geonames/composer.json, but I am still seeing the "Warning: Ambiguous class resolution" when running dumpautoload, any ideas? |
Hi,
If you're interested in reviewing the following changes as I know you're working on updating to 5.1
The migration part would need to be reworked as having the migrations files in the vendor folder creates warnings when running
composer dump-autoload
I read some people use blade template to store the migrations content:
DevFactoryCH/media#8 (comment)
Cheers