Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update all examples with strictDeps = true; #430

Merged
merged 2 commits into from
Oct 15, 2023
Merged

Conversation

ipetkov
Copy link
Owner

@ipetkov ipetkov commented Oct 15, 2023

Motivation

It can be a common source of rebuilds if buildInputs/nativeBuildInputs are not set up properly, plus it's good hygiene to always have it on.

There are no plans to make this a default behavior of mkCargoDerivation, however, as that would be a departure from mkDerivation which might end up being surprising

Fixes #403

Checklist

  • added tests to verify new behavior
  • added an example template or updated an existing one
  • updated docs/API.md (or general documentation) with changes
  • updated CHANGELOG.md

@ipetkov ipetkov enabled auto-merge (squash) October 15, 2023 22:14
@ipetkov ipetkov merged commit d4bddd0 into master Oct 15, 2023
8 checks passed
@ipetkov ipetkov deleted the strict-deps branch October 15, 2023 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should probably run with strictDeps = true
1 participant