-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cargoLib.cargoDeny: init #440
Conversation
3fe67b0
to
0f1199a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, and thanks for updating the docs as well!
While I was able to follow the various craneLib functions well enough to write cargoDeny, I have had more difficulty understanding the tests (under checks/), and I will need some assistance writing tests for craneLib.cargoDeny.
Sorry the test suite is a little messy! I think we can get started with just a single test which runs on the ./simple
crate. We don't need to test that cargo-deny
actually catches any specific issues, just that it's running successfully!
0f1199a
to
3deb608
Compare
3deb608
to
912d372
Compare
912d372
to
08fa629
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks! Just pushed a few minor fixes
Motivation
Add
craneLib.cargoDeny
, analogous tocraneLib.cargoAudit
but forcargo deny
, a tool for auditing the licenses and provenance of your crate's dependency graph.This tool can be used as a replacement for
cargo audit
, but unlikecargo audit
, which operates on theCargo.lock
file,cargo deny
operates on theCargo.toml
file, and so thecraneLib.cargoAudit
derivation has to be rebuilt on any source change, rather than only when the lock file changes. Because of this,craneLib.cargoAudit
does not run the security-advisoryaudit
check.Checklist
docs/API.md
(or general documentation) with changesCHANGELOG.md
While I was able to follow the variouscraneLib
functions well enough to writecargoDeny
, I have had more difficulty understanding the tests (underchecks/
), and I will need some assistance writing tests forcraneLib.cargoDeny
.