mkDummySrc: fix handling when src is already filtered #47
Conversation
|
|
||
| cargoTomlsBase = uncleanSrcBasePath; | ||
| inherit (uncleanFiles) cargoTomls; | ||
|
|
||
| cleanSrc = | ||
| let | ||
| adjustPaths = builtins.map (p: removePrefix uncleanSrcBasePath (toString p)); |
There was a problem hiding this comment.
Am I correct in saying that this was added in 4f2b1c4 but wasn't actually used (I'm assuming it was just leftover from an iteration of that commit)?
There was a problem hiding this comment.
Yep I think I was iterating on whether to make the filter on the next line as its own variable, but it looks like it was never used (since Nix is lazy it just ignores unused input 🤷 )
| then src.origSrc | ||
| else src; | ||
|
|
||
| uncleanSrcBasePath = (toString origSrc) + "/"; |
There was a problem hiding this comment.
I assume this is done to forcefully evaluate the source derivation? Wouldn't this already be evaluated in the call to findCargoFiles?
There was a problem hiding this comment.
I don't have a good enough intuitive understanding of how Nix treats paths and strings (and coercing between the two) to explain why this is needed... I did try taking it out and a bunch of tests failed so it's load bearing at some capacity 😅
Fixes #46