Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with comment for inline table key #583

Merged
merged 5 commits into from
Apr 21, 2024

Conversation

i1i1
Copy link
Contributor

@i1i1 i1i1 commented Apr 11, 2024

Motivation

If workspace features dependency and workspace crate uses it, it is always gets merged as regular table (not inline one) so comments ends up in the following position:

[
            # arbitrary
            dependencies.arbitrary ]

Take a look at the test for more info.

Fixes #527

Checklist

  • added tests to verify new behavior
  • added an example template or updated an existing one
  • updated docs/API.md (or general documentation) with changes
  • updated CHANGELOG.md

Copy link
Owner

@ipetkov ipetkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this, totally didn't realize toml_edit supported clearing comments like this! It also appears to resolve #527

@ipetkov ipetkov enabled auto-merge (squash) April 21, 2024 04:04
@ipetkov ipetkov merged commit 3dda6d4 into ipetkov:master Apr 21, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I think crane mangles my cargo.toml
2 participants