Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples: use member wildcard to avoid breaking if crates are renamed #728

Merged
merged 1 commit into from
Oct 27, 2024
Merged

examples: use member wildcard to avoid breaking if crates are renamed #728

merged 1 commit into from
Oct 27, 2024

Conversation

ipetkov
Copy link
Owner

@ipetkov ipetkov commented Oct 27, 2024

Motivation

Fixes #723

Checklist

  • added tests to verify new behavior
  • added an example template or updated an existing one
  • updated docs/API.md (or general documentation) with changes
  • updated CHANGELOG.md

@ipetkov ipetkov mentioned this pull request Oct 27, 2024
Closed
@ipetkov ipetkov enabled auto-merge (squash) October 27, 2024 20:15
@ipetkov ipetkov merged commit 498d9f1 into master Oct 27, 2024
19 checks passed
@ipetkov ipetkov deleted the workspace-crate-rename branch October 27, 2024 20:17
ulucs pushed a commit to ulucs/crane that referenced this pull request Dec 3, 2024
@ipetkov @ulucs
examples: use member wildcard to avoid breaking if crates are renamed (…
e11db6d 
…ipetkov#728)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

changing crate names in quick-start-workspace causes breakage (failed to load manifest)
1 participant
@ipetkov