Replace %2F with / in url for branch #760
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I found that the URL encoding that is put into the
Cargo.lock
file by cargo does not work in a nix build using crane, because crane does not decode the url in the generated source replacementconfig.toml
.FWIW, I know that this patch cannot be the actual solution to the problem, but it is a proof of concept that this is the issue.
We (@TheNeikos and I) used this repository:
https://github.com/cloudroots/erased-serde
with this branch:
feature/make_make_serializer_public
in the repo where we encountered the issue (unfortunately, that repo is still proprietary and closed source).In the
branch
setting in the generated source replacementconfig.toml
isbranch = "feature%2Fmake_make_serializer_public"
- which does not work with cargo and results in cargo failing during buildtime (unfortunately withTemporary failure in name resolution for github.com
, which is not really helping here).Checklist
docs/API.md
(or general documentation) with changesCHANGELOG.md