feat: helia-lan-discovery example #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related: libp2p/js-libp2p#2012 |
|
Also related: libp2p/js-libp2p#2013 |
SgtPooki
changed the title
|
Merged this even though test-monorepo is failing |
😞 |
|
This was missing a repo to copy the examples to so it further broke the build. I've updated the instructions for adding new examples which were a little out of date, I think it's all present & correct now - https://github.com/ipfs-examples/helia-examples#how-to-add-a-new-example |
|
That said the tests are pretty unreliable, the lan example ones seem to run forever sometimes. There was a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
user reached out on slack about peer discovery not working quite right with Helia, so i decided to throw together some code and try it out
This example is now working and has some very basic tests