Skip to content
This repository has been archived by the owner on Jan 12, 2024. It is now read-only.

fix: update vite example #431

Merged
merged 8 commits into from
Sep 8, 2022
Merged

fix: update vite example #431

merged 8 commits into from
Sep 8, 2022

Conversation

pleerock
Copy link
Contributor

@pleerock pleerock commented Aug 5, 2022 •
edited
Loading

as discussed in #4147

@pleerock
fix vite example
0ef940a 
as discussed in #4147
@achingbrain
Copy link
Contributor

This is blocked by vitejs/vite#7576 - vite dev works because vite uses esbuild to bundle the code, vite build does not because vite uses a bit of rollup with a whole bunch of custom plugins that don't quite work the same way.

@achingbrain achingbrain changed the title fix vite example fix: vite example Sep 7, 2022
@achingbrain achingbrain changed the title fix: vite example fix: fix vite example Sep 7, 2022
@achingbrain achingbrain changed the title fix: fix vite example fix: update vite example Sep 7, 2022
@achingbrain achingbrain merged commit b2fd458 into ipfs-examples:master Sep 8, 2022
@achingbrain achingbrain mentioned this pull request Sep 8, 2022
Closed
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pleerock @achingbrain