Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(vsmgr): support token-included api infos #361

Merged
merged 2 commits into from
Aug 3, 2022
Merged

feat(vsmgr): support token-included api infos #361

merged 2 commits into from
Aug 3, 2022

Conversation

dtynn
Copy link
Contributor

@dtynn dtynn commented Aug 2, 2022 •
edited
Loading

关联的Issues (Related Issues)

resolve #358

改动 (Proposed Changes)

  • 提供一种可以为每一个单一 rpc 服务（实例）配置独立的 token 的方式

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前，需要确保 / Before you mark the PR ready for review, please make sure that:

  • 具有清晰明确的 commit message / All commits have a clear commit message.
  • 包含必要的测试用例 / This PR has tests for new functionality or change in behaviour
  • 包含必要的指南或文档 / If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included
  • 通过必要的检查项 / All checks are green

@dtynn dtynn self-assigned this Aug 2, 2022
@dtynn dtynn requested a review from remakeZK August 2, 2022 08:52
@dtynn dtynn added this to the v0.5.0 milestone Aug 2, 2022
@dtynn
Copy link
Contributor Author

dtynn commented Aug 2, 2022

@litai686 plz review this pr

remakeZK
remakeZK approved these changes Aug 2, 2022
View reviewed changes
Copy link
Contributor

@remakeZK remakeZK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

litai686
litai686 approved these changes Aug 2, 2022
View reviewed changes
Copy link

@litai686 litai686 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect

@dtynn dtynn merged commit 2f823b1 into main Aug 3, 2022
@dtynn dtynn deleted the feat/dtynn/customized_token_in_api_infos branch August 3, 2022 01:38
This was referenced Aug 3, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@litai686 litai686 litai686 approved these changes

@remakeZK remakeZK remakeZK approved these changes

Assignees

@dtynn dtynn

Labels
None yet
Projects
No open projects
venus-cluster
Status: Done
Milestone
v0.5.0
3 participants
@dtynn @litai686 @remakeZK