Fix: crush caused by creation 0 interval timer #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simlecode
approved these changes
Jun 10, 2022
litai686
pushed a commit
to litai686/venus-market
that referenced
this pull request
Jul 30, 2022
…/docs/dtynn/prepare_for_v0.2.0 Docs/dtynn/prepare for v0.2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
新引入的 venus-gateway 新增加了 ClearRequestInterval 配置项
此配置项用于创建定时器, 定时检查过期的请求.
在venus-gateway中, 没有对此值的有效性进行判断, 如果不设置将最终导致程序panic.
https://github.com/ipfs-force-community/venus-gateway/blob/45c7c99119e76f492b8f011f85834684c53e842c/types/base_event.go#L123-L125
改进
fix: validate config to avoid creation a 0 interval timer sophon-gateway#53