Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: create incorrect signer type #150

Merged
merged 3 commits into from
Jun 17, 2022

Conversation

zl03jsj
Copy link
Contributor

@zl03jsj zl03jsj commented Jun 17, 2022

fix: 创建了错误的signer类型, 导致签名失败的问题.

@zl03jsj zl03jsj requested a review from simlecode June 17, 2022 07:11
@zl03jsj zl03jsj self-assigned this Jun 17, 2022
@zl03jsj zl03jsj added the C-bug Category: This is a bug label Jun 17, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2022

Codecov Report

Merging #150 (879ec54) into prep/v2.2.0-rc2 (b7717c8) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           prep/v2.2.0-rc2     #150      +/-   ##
===================================================
+ Coverage            18.75%   18.77%   +0.01%     
===================================================
  Files                  170      170              
  Lines                17830    17827       -3     
===================================================
+ Hits                  3344     3347       +3     
+ Misses               14052    14047       -5     
+ Partials               434      433       -1     
Flag Coverage Δ
unittests 18.77% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/clients/sign_client.go 0.00% <0.00%> (ø)
cmd/venus-market/main.go 0.00% <0.00%> (ø)
cmd/venus-market/pool-run.go 0.00% <0.00%> (ø)
cmd/venus-market/solo-run.go 0.00% <0.00%> (ø)
config/config.go 0.00% <ø> (ø)
models/badger/paych.go 73.88% <0.00%> (+1.66%) ⬆️

@zl03jsj zl03jsj force-pushed the fix/incorrect-signer-type branch from 6f45ae4 to 3efac96 Compare June 17, 2022 07:50
@zl03jsj zl03jsj requested a review from hunjixin June 17, 2022 07:51
Copy link
Contributor

@hunjixin hunjixin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hunjixin hunjixin merged commit eb84085 into prep/v2.2.0-rc2 Jun 17, 2022
@zl03jsj zl03jsj deleted the fix/incorrect-signer-type branch June 17, 2022 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants