Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/tanlang/user data isolation / 用户数据隔离 #254

Merged
merged 7 commits into from
Jan 10, 2023

Conversation

LinZexiao
Copy link
Collaborator

@LinZexiao LinZexiao commented Dec 6, 2022

关联的Issues (Related Issues)

involve filecoin-project/venus#5384

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

实现细节 (Detail)

不需要做用户数据隔离的接口

PiecesListPieces //perm:read
PiecesListCidInfos //perm:read
PiecesGetPieceInfo //perm:read
PiecesGetCIDInfo //perm:read
MessagerWaitMessage //perm:read
MessagerGetMessage //perm:read
NetAddrsListen //perm:read
ID //perm:read
ResponseMarketEvent //perm:read
ListenMarketEvent //perm:read
ListPieceStorageInfos //perm:read
MarketListAsk //perm:read
MarketListRetrievalAsk //perm:read

不对普通用户开放的接口

MarketListDataTransfers //perm:admin
MarketDataTransferUpdates //perm:admin
MarketRestartDataTransfer //perm:admin
MarketCancelDataTransfer //perm:admin
ImportV1Data //perm:admin
MarketPublishPendingDeals //perm:admin
DagstoreListShards //perm:admin
DagstoreInitializeShard //perm:admin
DagstoreRecoverShard //perm:admin
DagstoreInitializeAll //perm:admin
DagstoreInitializeStorage //perm:admin
DagstoreGC //perm:admin
AddFsPieceStorage //perm:admin
AddS3PieceStorage //perm:admin
RemovePieceStorage //perm:admin

暂时不进行用户数据隔离的接口

MarketListRetrievalDeals //perm:read

进行用户数据隔离的接口

ActorList //perm:read
ActorExist //perm:read
ActorSectorSize //perm:read
MarketListDeals //perm:read

MarketGetDealUpdates //perm:read
MarketListIncompleteDeals //perm:read
MarketGetAsk //perm:read

MarketGetRetrievalAsk //perm:read

DealsConsiderOnlineStorageDeals //perm:read
DealsConsiderOnlineRetrievalDeals //perm:read
DealsPieceCidBlocklist //perm:read
DealsConsiderOfflineStorageDeals //perm:read
DealsConsiderOfflineRetrievalDeals //perm:read
DealsConsiderVerifiedStorageDeals //perm:read
DealsConsiderUnverifiedStorageDeals //perm:read
SectorGetExpectedSealDuration //perm:read
DealsMaxStartDelay //perm:read

DealsPublishMsgPeriod //perm:read
MarketMaxDealsPerPublishMsg //perm:read

DealsMaxProviderCollateralMultiplier //perm:read
DealsMaxPublishFee //perm:read
MarketMaxBalanceAddFee //perm:read

GetDeals //perm:read
GetUnPackedDeals //perm:read

PaychVoucherList //perm:read

GetStorageDealStatistic //perm:read
GetRetrievalDealStatistic //perm:read

MarketImportDealData //perm:write
MarketImportPublishedDeal //perm:write

MarketPendingDeals //perm:write
DealsSetConsiderOnlineStorageDeals //perm:write
DealsSetConsiderOnlineRetrievalDeals //perm:write
DealsSetPieceCidBlocklist //perm:write
DealsSetConsiderOfflineStorageDeals //perm:write
DealsSetConsiderOfflineRetrievalDeals //perm:write
DealsSetConsiderVerifiedStorageDeals //perm:write
DealsSetConsiderUnverifiedStorageDeals //perm:write
SectorSetExpectedSealDuration //perm:write
DealsSetMaxStartDelay //perm:write

DealsSetPublishMsgPeriod //perm:write
MarketSetMaxDealsPerPublishMsg //perm:write
DealsSetMaxProviderCollateralMultiplier //perm:write
DealsSetMaxPublishFee //perm:write
MarketSetMaxBalanceAddFee //perm:write
MessagerPushMessage //perm:write
MarkDealsAsPacking //perm:write
UpdateDealOnPacking //perm:write
UpdateDealStatus //perm:write
AssignUnPackedDeals //perm:write
UpdateStorageDealStatus //perm:write

MarketAddBalance //perm:sign
MarketGetReserved //perm:sign
MarketReserveFunds //perm:sign
MarketReleaseFunds //perm:sign
MarketWithdraw //perm:sign

MarketSetAsk //perm:admin
MarketSetRetrievalAsk //perm:admin
DealsImportData //perm:admin
OfflineDealImport //perm:admin
MarketDataTransferPath //perm:admin
MarketSetDataTransferPath //perm:admin

接口变更

删除

ImportV1Data //perm:admin

权限升级

  • read -> admin
    MarketListDataTransfers //perm:admin
    MarketDataTransferUpdates //perm:admin
    MarketRestartDataTransfer //perm:admin
    MarketCancelDataTransfer //perm:admin

api/impl/venus_market.go Outdated Show resolved Hide resolved
api/impl/venus_market.go Outdated Show resolved Hide resolved
api/impl/venus_market.go Outdated Show resolved Hide resolved
api/impl/venus_market.go Outdated Show resolved Hide resolved
@LinZexiao LinZexiao marked this pull request as draft December 6, 2022 03:00
@LinZexiao LinZexiao force-pushed the feat/tanlang/user-data-isolation branch 2 times, most recently from 9202890 to 12816fa Compare December 6, 2022 03:25
@LinZexiao LinZexiao force-pushed the feat/tanlang/user-data-isolation branch from 12816fa to 72634bc Compare December 6, 2022 10:02
@LinZexiao LinZexiao changed the base branch from master to dev/v2.6.0 December 7, 2022 05:16
@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2022

Codecov Report

❗ No coverage uploaded for pull request base (dev/v2.6.0@5486870). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             dev/v2.6.0     #254   +/-   ##
=============================================
  Coverage              ?   23.29%           
=============================================
  Files                 ?      174           
  Lines                 ?    20055           
  Branches              ?        0           
=============================================
  Hits                  ?     4671           
  Misses                ?    14609           
  Partials              ?      775           
Flag Coverage Δ
unittests 23.29% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

api/impl/venus_market.go Outdated Show resolved Hide resolved
api/impl/venus_market.go Outdated Show resolved Hide resolved
@LinZexiao LinZexiao force-pushed the feat/tanlang/user-data-isolation branch from 93629e1 to 07e5278 Compare December 19, 2022 05:11
MarketGetDealUpdates
MarketImportDealData
@LinZexiao LinZexiao force-pushed the feat/tanlang/user-data-isolation branch from 07e5278 to 11e0fe4 Compare December 29, 2022 02:35
@LinZexiao LinZexiao marked this pull request as ready for review December 30, 2022 00:57
@LinZexiao LinZexiao requested a review from hunjixin January 9, 2023 09:48
@hunjixin hunjixin merged commit 4753591 into dev/v2.6.0 Jan 10, 2023
@hunjixin hunjixin deleted the feat/tanlang/user-data-isolation branch January 10, 2023 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants