Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PaymentAddress uses a fake address when retrieval data does not … #312

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

simlecode
Copy link
Collaborator

…exist

关联的Issues (Related Issues)

close filecoin-project/venus#5849

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@simlecode simlecode self-assigned this Mar 30, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2023

Codecov Report

Merging #312 (c425775) into master (8e768a5) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #312      +/-   ##
==========================================
- Coverage   22.54%   22.54%   -0.01%     
==========================================
  Files         180      180              
  Lines       21025    21030       +5     
==========================================
+ Hits         4741     4742       +1     
- Misses      15510    15514       +4     
  Partials      774      774              
Flag Coverage Δ
unittests 22.54% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
retrievalprovider/stream_handler.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@simlecode simlecode force-pushed the fix/payment-address-undef branch from 554d3f7 to c425775 Compare March 30, 2023 07:02
@hunjixin hunjixin merged commit a2b889f into master Mar 30, 2023
@hunjixin hunjixin deleted the fix/payment-address-undef branch March 30, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[venus-market]检索时 payload 不存在,marshal 返回结果失败
3 participants