Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: payload size is 0 when generate index #429

Merged
merged 3 commits into from
Sep 12, 2023
Merged

Conversation

simlecode
Copy link
Collaborator

@simlecode simlecode commented Sep 12, 2023

关联的Issues (Related Issues)

close

改动 (Proposed Changes)

  1. 一个piece发了两次,第一次失败了,第二次成功了,生成索引的时候是按piececid来查找piece信息,会找到第一次发的订单,所以有些信息找不到导致生成索引失败了
  2. 增加对 MongoDB URL 的检查
  3. 修复 droplet-client 启动失败

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2023

Codecov Report

Merging #429 (78a24f9) into master (55c2838) will decrease coverage by 0.03%.
The diff coverage is 45.45%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #429      +/-   ##
==========================================
- Coverage   20.52%   20.49%   -0.03%     
==========================================
  Files         193      193              
  Lines       23635    23640       +5     
==========================================
- Hits         4850     4844       -6     
- Misses      17996    18004       +8     
- Partials      789      792       +3     
Flag Coverage Δ
unittests 20.49% <45.45%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage
config/modules.go 0.00%
dagstore/wrapper.go 0.00%
models/badger/storage_deal.go 40.00%
models/mysql/storage_deal.go 75.00%

Copy link
Collaborator

@LinZexiao LinZexiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LinZexiao LinZexiao merged commit c0a36e1 into master Sep 12, 2023
@LinZexiao LinZexiao deleted the fix/generate-index branch September 12, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants