Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/adding stm annotations #99

Merged
merged 4 commits into from
Nov 21, 2022
Merged

Conversation

zl03jsj
Copy link
Contributor

@zl03jsj zl03jsj commented Nov 16, 2022

关联的Issues (Related Issues)

closes filecoin-project/venus#5385
sub task of: filecoin-project/venus#5220

改动 (Proposed Changes)

  1. 补充单元测试, 增加STM注解。
  2. 增加circleci检查, 用于增强STM。

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@codecov-commenter
Copy link

Codecov Report

Merging #99 (109788a) into master (2ca40c7) will increase coverage by 1.54%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
+ Coverage   63.99%   65.54%   +1.54%     
==========================================
  Files          29       29              
  Lines        1961     1962       +1     
==========================================
+ Hits         1255     1286      +31     
+ Misses        642      616      -26     
+ Partials       64       60       -4     
Flag Coverage Δ
unittests 65.54% <100.00%> (+1.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
proofevent/proof_event.go 90.44% <100.00%> (+0.07%) ⬆️
walletevent/wallet_client.go 67.14% <0.00%> (-2.15%) ⬇️
walletevent/wallet_conn_mgr.go 94.28% <0.00%> (+0.57%) ⬆️
marketevent/market_client.go 70.37% <0.00%> (+2.77%) ⬆️
proofevent/proof_client.go 70.00% <0.00%> (+3.00%) ⬆️
walletevent/wallet_event.go 77.83% <0.00%> (+9.35%) ⬆️
validator/miner_validator.go 100.00% <0.00%> (+36.84%) ⬆️

Copy link
Contributor

@diwufeiwen diwufeiwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@LinZexiao LinZexiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LinZexiao LinZexiao merged commit a27a4e6 into master Nov 21, 2022
@LinZexiao LinZexiao deleted the feat/adding-stm-annotations branch November 21, 2022 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

venus-gateway 完善必要的测试用例,添加STM注解
4 participants