Skip to content

Commit

Permalink
chore: update metrics
Browse files Browse the repository at this point in the history
  • Loading branch information
LinZexiao committed Jul 7, 2023
1 parent 4106db5 commit 298517f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions metrics/trace.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,13 @@ func SetupJaeger(lc fx.Lifecycle, tcfg *metrics.TraceConfig) error {
return nil
}

exporter, err := metrics.RegisterJaeger(tcfg.ServerName, tcfg)
exporter, err := metrics.SetupJaegerTracing(tcfg.ServerName, tcfg)
if err != nil {
return err
}
lc.Append(fx.Hook{
OnStop: func(ctx context.Context) error {
metrics.UnregisterJaeger(exporter)
metrics.ShutdownJaeger(ctx, exporter)

Check failure on line 25 in metrics/trace.go

View workflow job for this annotation

GitHub Actions / check / check

Error return value of `metrics.ShutdownJaeger` is not checked (errcheck)
return nil
},
})
Expand Down

0 comments on commit 298517f

Please sign in to comment.