Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: opt convert params #276

Merged
merged 2 commits into from
Nov 9, 2022
Merged

chore: opt convert params #276

merged 2 commits into from
Nov 9, 2022

Conversation

simlecode
Copy link
Collaborator

@simlecode simlecode commented Nov 8, 2022

关联的Issues (Related Issues)

close

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@simlecode simlecode self-assigned this Nov 8, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #276 (4dce05a) into master (d9d0dd5) will increase coverage by 0.05%.
The diff coverage is 65.07%.

❗ Current head 4dce05a differs from pull request most recent head 4d57f7e. Consider uploading reports for the commit 4d57f7e to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #276      +/-   ##
==========================================
+ Coverage   53.97%   54.02%   +0.05%     
==========================================
  Files          62       62              
  Lines        6611     6602       -9     
==========================================
- Hits         3568     3567       -1     
+ Misses       2758     2750       -8     
  Partials      285      285              
Flag Coverage Δ
unittests 54.02% <65.07%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
utils/convert_params.go 71.17% <65.07%> (+7.00%) ⬆️
service/address_service.go 57.60% <0.00%> (-3.27%) ⬇️

Copy link
Contributor

@diwufeiwen diwufeiwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diwufeiwen diwufeiwen merged commit 7e66881 into master Nov 9, 2022
@diwufeiwen diwufeiwen deleted the chore/opt-convert-params branch November 9, 2022 01:44
diwufeiwen pushed a commit that referenced this pull request Nov 24, 2022
* fix: fix memory leak (#272)

* chore: bump to version v1.8.0-rc3 (#274)

* chore: update venus & venus-auth

* chore: bump version to v1.8.0-rc3

* chore: opt convert params (#276)

* chore: opt convert params

* chore: add test

* chore: bump version to 1.8.0 (#283)

* chore: upgrade venus & venus-auth

* chore: bump version to 1.8.0

* chore: add badges (#282)

* feat: circleci tests for STM enhancement (#284)

* chore: migrate docker script (#285)

Co-authored-by: Mike <41407352+hunjixin@users.noreply.github.com>
Co-authored-by: zl <zl03jsj@163.com>
Co-authored-by: LinZexiao <55120714+LinZexiao@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

3 participants