Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/tanlang/divide return field of message #279

Merged

Conversation

LinZexiao
Copy link
Collaborator

@LinZexiao LinZexiao commented Nov 11, 2022

关联的Issues (Related Issues)

close filecoin-project/venus#5197

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

models/mysql/message.go Outdated Show resolved Hide resolved
models/repo/message_repo.go Outdated Show resolved Hide resolved
models/sqlite/message.go Outdated Show resolved Hide resolved
@LinZexiao LinZexiao force-pushed the feat/tanlang/divide-return-field-of-message branch from 8d2a2ba to d1647ea Compare November 15, 2022 00:43
@LinZexiao LinZexiao requested a review from simlecode November 15, 2022 01:39
@LinZexiao LinZexiao force-pushed the feat/tanlang/divide-return-field-of-message branch from d1647ea to bcc456b Compare November 15, 2022 01:51
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release/v1.9.0-pre-rc1@9e0cd03). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                    @@
##             release/v1.9.0-pre-rc1     #279   +/-   ##
=========================================================
  Coverage                          ?   54.63%           
=========================================================
  Files                             ?       69           
  Lines                             ?     7007           
  Branches                          ?        0           
=========================================================
  Hits                              ?     3828           
  Misses                            ?     2878           
  Partials                          ?      301           
Flag Coverage Δ
unittests 54.63% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Collaborator

@simlecode simlecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LinZexiao LinZexiao requested a review from diwufeiwen November 15, 2022 03:19
@diwufeiwen diwufeiwen merged commit dd9b58e into release/v1.9.0-pre-rc1 Nov 15, 2022
@diwufeiwen diwufeiwen deleted the feat/tanlang/divide-return-field-of-message branch November 15, 2022 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

4 participants