Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

annotate a configuration file using comments in toml format / toml注释的格式进行参数说明 #355

Merged
merged 2 commits into from
Jul 17, 2023

Conversation

elvin-du
Copy link
Collaborator

@elvin-du elvin-du commented Jul 7, 2023

关联的Issues (Related Issues)

close

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@elvin-du elvin-du requested a review from LinZexiao July 7, 2023 03:11
@elvin-du elvin-du self-assigned this Jul 7, 2023
@elvin-du elvin-du changed the title annotate a configuration file using comments in toml format annotate a configuration file using comments in toml format / toml注释的格式进行参数说明 Jul 7, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #355 (c8f5916) into master (f84b2f2) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #355   +/-   ##
=======================================
  Coverage   53.63%   53.63%           
=======================================
  Files          74       74           
  Lines        8109     8109           
=======================================
  Hits         4349     4349           
  Misses       3410     3410           
  Partials      350      350           
Flag Coverage Δ
unittests 53.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@elvin-du
Copy link
Collaborator Author

config.toml中的log配置不再使用,请使用flag进行log的设置。所以删除其配置。

Copy link
Contributor

@Fatman13 Fatman13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Fatman13 Fatman13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Fatman13 Fatman13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@LinZexiao LinZexiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LinZexiao LinZexiao merged commit c29565d into master Jul 17, 2023
@LinZexiao LinZexiao deleted the docs/elvindu/add-config-explanation branch July 17, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants