Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add asc and by update at to msg query params #357

Merged
merged 4 commits into from
Jul 19, 2023

Conversation

LinZexiao
Copy link
Collaborator

关联的Issues (Related Issues)

close

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@LinZexiao LinZexiao requested a review from simlecode July 18, 2023 08:20
@LinZexiao LinZexiao force-pushed the feat/add-asc-and-by-update-at-to-msg-query-params branch 2 times, most recently from fd961e1 to 9f94d44 Compare July 19, 2023 01:55
@LinZexiao LinZexiao force-pushed the feat/add-asc-and-by-update-at-to-msg-query-params branch from 9f94d44 to 0c39aab Compare July 19, 2023 02:19
@codecov-commenter
Copy link

Codecov Report

Merging #357 (0c39aab) into master (c29565d) will increase coverage by 0.21%.
The diff coverage is 84.44%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #357      +/-   ##
==========================================
+ Coverage   53.64%   53.85%   +0.21%     
==========================================
  Files          74       74              
  Lines        8109     8166      +57     
==========================================
+ Hits         4350     4398      +48     
- Misses       3409     3416       +7     
- Partials      350      352       +2     
Flag Coverage Δ
unittests 53.85% <84.44%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
metrics/trace.go 47.05% <0.00%> (+2.61%) ⬆️
models/mysql/message.go 75.18% <79.54%> (+0.31%) ⬆️
models/sqlite/message.go 82.32% <93.18%> (+0.55%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Collaborator

@simlecode simlecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@simlecode simlecode merged commit b117687 into master Jul 19, 2023
1 check passed
@simlecode simlecode deleted the feat/add-asc-and-by-update-at-to-msg-query-params branch July 19, 2023 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants