Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update config description / 更新config的解释 #209

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

elvin-du
Copy link
Collaborator

关联的Issues (Related Issues)

close

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@elvin-du elvin-du added the documentation Improvements or additions to documentation label Jul 12, 2023
@elvin-du elvin-du requested a review from simlecode July 12, 2023 02:04
@elvin-du elvin-du self-assigned this Jul 12, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2023

Codecov Report

Merging #209 (994e517) into master (462e6e7) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #209   +/-   ##
=======================================
  Coverage   31.38%   31.38%           
=======================================
  Files          58       58           
  Lines        3983     3983           
=======================================
  Hits         1250     1250           
  Misses       2578     2578           
  Partials      155      155           
Flag Coverage Δ
unittests 31.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@elvin-du elvin-du requested a review from Fatman13 July 13, 2023 01:33
Copy link
Contributor

@Fatman13 Fatman13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Fatman13 Fatman13 merged commit 35304ee into master Jul 17, 2023
1 check passed
@Fatman13 Fatman13 deleted the docs/elvindu/add-more-description-for-config branch July 17, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants