This repository has been archived by the owner on Apr 29, 2020. It is now read-only.
Added group diag
#40
Merged
Added group diag
#40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| The given timeout will be decremented 2s at every network hop, | ||
| ensuring peers try to return their diagnostics before the initiator's | ||
| timeout. If the timeout is too small, some peers may not be reached. | ||
| 30s and 60s are reasonable timeout values, though network vary. |
There was a problem hiding this comment.
"though network vary" sounds wrong
|
@whyrusleeping Need your feedback on this. These need to be changed. |
|
Note: 0.4.0 has an extra subcommand to ipfs diag
|
|
@RichardLitt Timeout is global: find the relevant go-code and put it in a thing. |
|
Added subcmds. Also edited them, so, this PR should be merged first. ipfs/kubo#2487 |
RichardLitt
force-pushed
the
feature/diag
branch
from
4325e00 to
3adbdfe
Compare
|
Final thing to do: Add a PR for timeout. However, the rest of this is RFCR and then RFM. |
|
Mentioned PR in ipfs/kubo#2583. Merging this as that isn't relevant to the direct code in this PR. |
RichardLitt
force-pushed
the
feature/diag
branch
from
43c56a4 to
0e92ddf
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.