This repository has been archived by the owner on Apr 29, 2020. It is now read-only.
Update refs following go-ipfs#2812 #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| "Ref": "QmNXFHU3KzhzXN9pZ5Bdghk3LYGj58Xzi7WvMVVoykdLxA", | ||
| "Err": "" | ||
| } |
There was a problem hiding this comment.
As it is NDJSON the objects should span a one line. In the response of the API it is also one line per object.
There was a problem hiding this comment.
I automatically format it to make it more readable, as all of the JSON is basically scrunched up in the terminal.
I could add a note about this to make this clear?
There was a problem hiding this comment.
Yeah, as this format is in theory incompatible with NDJSON.
There was a problem hiding this comment.
Opened #100. Can this PR be merged?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.