Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

List of API changes for app developers (e.g. files.cat)? #184

Closed
mitra42 opened this issue Dec 17, 2017 · 3 comments · Fixed by ipfs/js-ipfs#1355
Closed

List of API changes for app developers (e.g. files.cat)? #184

mitra42 opened this issue Dec 17, 2017 · 3 comments · Fixed by ipfs/js-ipfs#1355
Labels

Comments

@mitra42
Copy link

mitra42 commented Dec 17, 2017

Is there any documentation with a list of the API changes suitable for app developers.

For example ...I just got bitten by the change of files.cat just started returning Buffer instead of a Stream. I know the change was announced back in October in #162 but that is in development, so its only now with the 0.27 that it bites app developers.

Is there a full list of API changes from 0.26 to 0.27 so we can check for other issues?

The only other one I know of is that app developers who use WebRTC should switch their config to websockets star.

Have I missed some list ?

@daviddias
Copy link
Contributor

We've been announcing new releases -- ipfs/js-ipfs#1095 -- through all of our most used channels (IRC, Github, Twitter and Reddit). These announcements serve as a changelog and a feature highlight so that devs know beforehand what to expect on next release and have time to update.

We also invite everyone that is using js-ipfs to tell us how and where so that we can run the tests before any release. If you have a strong test suite and your codebase always passing on master, then you just have to add it to the list -- https://github.com/ipfs/js-ipfs/blob/master/RELEASE.md -- and I'll let you know which tests failed so that you know what you need to pay attention to.

With regards to the files.cat returning a buffer. That was actually one feature request you submitted back at #164 and got accepted with #162, that PR shows the diff between the old and new API, you can find the changes there.

As for your last question, I believe you didn't miss anything else :)

@mitra42
Copy link
Author

mitra42 commented Dec 18, 2017

Hi David - yes, no issues with having made that request and it being changed, it just that I didn't realize it had changed (even though I made the request - I think partly I missed it because Issue #164 was closed before the fix was actually done).

#1095 gives a good list of NEW features - which is great, I can add the ones I need incrementally. BUT can I suggest adding a section on each release that highlights things that have (intentionally) changed, I'm sure it would help app developers find the things that break previously working code. Especially since we can't actually make the change in our code even when the fix is done, only when the release gets pushed.

@daviddias
Copy link
Contributor

I suggest adding a section on each release that highlights things that have (intentionally) changed

I like that 👍

alanshaw added a commit to ipfs/js-ipfs that referenced this issue May 15, 2018
resolves ipfs-inactive/interface-js-ipfs-core#184

License: MIT
Signed-off-by: Alan Shaw <alan@tableflip.io>
@ghost ghost assigned alanshaw May 15, 2018
@ghost ghost added in progress and removed backlog labels May 15, 2018
@ghost ghost removed the in progress label May 15, 2018
daviddias pushed a commit to ipfs/js-ipfs that referenced this issue May 15, 2018
resolves ipfs-inactive/interface-js-ipfs-core#184

License: MIT
Signed-off-by: Alan Shaw <alan@tableflip.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants