DHT API

[daviddias]

WIP

• API calls
  • ipfs.dht.findpeer
  • ipfs.dht.get
  • ipfs.dht.put
  • ipfs.dht.query
  • ipfs.dht.findprovs
• Works in js-ipfs This will be left for milestone 6 of js-ipfs
• Works in js-ipfs-api
• requires:
  • ipfsFactory - Tests that require more than one IPFS node #53

[victorb]

Build fails because I've set the npm test to fail instead of invalid command. Merging #74 will make us a have a valid CI for CircleCI

[daviddias]

@victorbjelkholm do you have a branch of these tests running on js-ipfs-api?

[daviddias]

typo: xdrescribe)

[victorb]

Pending test ;)

[daviddias]

The tests need to be updated to follow the same pattern of the remaining tests in the interface-ipfs-core, the pattern is:

• have a section for "callback API" and heavily test that one
• be creative about tests, if you can make them faster or find bugs in the impl through then, big 👍
• have a section for "promise API" and test at least each function once

Remember that once these things get merged, then it becomes official docs for everyone that consumes these APIs, it is very important to be very careful.

[victorb]

@diasdavid

@victorbjelkholm do you have a branch of these tests running on js-ipfs-api?

Yeah, over here: ipfs-inactive/js-ipfs-http-client#385

have a section for "callback API" and heavily test that one

👍

be creative about tests, if you can make them faster or find bugs in the impl through then, big 👍

👍

have a section for "promise API" and test at least each function once

Hm, not so sure about this one. The promise API should be tested at one place, to make sure promisify is working correctly, but I don't think we need to test every single function in both the callback way and promise. Makes more sense to have a couple of tests to make sure that one way is working, then always stick with the other otherwise.

[daviddias]

having a test for each method (not all combinations, just a test for each method) has detected in the past missing 'promisify' wraps.

[daviddias]

@victorbjelkholm I believe you are still on top of this, correct?

[victorb]

@diasdavid Yessir!

[victorb]

@diasdavid tests are passing, should be ready to be merged so we can move on with ipfs-inactive/js-ipfs-http-client#385

[daviddias]

awesome :D