Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

fix: handle err on both start and stop echo-server #569

Merged
merged 3 commits into from
Dec 11, 2019
Merged

fix: handle err on both start and stop echo-server #569

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bc7ad36
fix: handle err on both start and stop echo-server
Dec 9, 2019
fa7cebc
fix: add 'error' event to both server start and close
Dec 11, 2019
fe0899e
chore: code review changes
Dec 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions src/utils/echo-http-server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,21 @@ module.exports.createServer = () => {

const server = http.createServer(handler)

server.start = (opts) => new Promise(
(resolve) => server.listen(Object.assign({ port: defaultPort, host: '127.0.0.1' }, opts), resolve)
)
server.start = (opts) => new Promise((resolve, reject) => {
server.once('error', reject)
server.listen(Object.assign({ port: defaultPort, host: '127.0.0.1' }, opts), () => {
server.removeListener('error', reject)
resolve()
})
})

server.stop = () => new Promise((resolve) => server.close(resolve))
server.stop = () => new Promise((resolve, reject) => {
server.once('error', reject)
server.close((err) => {
server.removeListener('error', reject)
err ? reject(err) : resolve()
})
})

return server
}
Expand Down