This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
Remove reliance on external services for util.addFromURL tests #803
Assignees
Comments
alanshaw
added a commit
that referenced
this issue
Aug 14, 2018
Relying on external URLs makes our tests dependent on the availability and response time of these services as well as not being able to run without an internet connection. This PR removes those requests to external URLs and instead spins up test HTTP(s) servers as they are needed to serve the content that `ipfs.util.addFromURL` consumes. resolves #803 License: MIT Signed-off-by: Alan Shaw <alan@tableflip.io>
ghost
assigned
alanshaw
added a commit
that referenced
this issue
Aug 15, 2018
Relying on external URLs makes our tests dependent on the availability and response time of these services as well as not being able to run without an internet connection. This PR removes those requests to external URLs and instead spins up test HTTP(s) servers as they are needed to serve the content that `ipfs.util.addFromURL` consumes. This PR also strengthens some of the tests to make assertions that the result received by `ipfs.util.addFromURL` is the same as the result of adding the data directly using `ipfs.add`. resolves #803 License: MIT Signed-off-by: Alan Shaw <alan@tableflip.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The
addFromURLtests call out to URLs on the internet to add content to IPFS. This makes our tests dependent on the availability and response time of these services. Instead we should spin up a mock node server to respond to these requests for each test.https://github.com/ipfs/js-ipfs-api/blob/a8f9a43064930c816b0e73dbc1674a313cf1baca/test/util.spec.js#L115-L197
The text was updated successfully, but these errors were encountered: