This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
refactor: use fetch for ipfs.cat #1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
alanshaw
commented
Sep 10, 2019
src/lib/error-handler.js
Outdated
| // | ||
| // If the body in the clone is not consumed or destroyed the highwater mark | ||
| // will be reached (for large payloads) and stop the real body from flowing. | ||
| if (isNode) response.body.destroy() |
There was a problem hiding this comment.
ky has some, uh, interesting caveats.
There was a problem hiding this comment.
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
1 task
hugomrdias
suggested changes
Sep 11, 2019
| for await (const chunk of toIterable(res.body)) { | ||
| yield Buffer.from(chunk) | ||
| } | ||
| })() |
There was a problem hiding this comment.
Its a generator function that needs to be called to obtain the generator. I can split this out into a definition and a return of the called function if you think it’ll be easier to understand?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.