This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
fix: repo stat for non-numeric string values #1148
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
@PedroMiguelSS please add a test to https://github.com/ipfs/interface-js-ipfs-core/blob/master/src/repo/stat.js so we can verify this works. Shout if you need a hand with anything. |
PedroMiguelSS
force-pushed
the
fix/repo-stat
branch
from
fdf70d9 to
4c0889c
Compare
PedroMiguelSS
force-pushed
the
fix/repo-stat
branch
2 times, most recently
from
c1c385c to
754c0a4
Compare
PedroMiguelSS
force-pushed
the
fix/repo-stat
branch
from
754c0a4 to
eef5762
Compare
|
Can I get a second review here, please? @alanshaw @hugomrdias @achingbrain Please note that this PR depends on ipfs-inactive/interface-js-ipfs-core#554. |
PedroMiguelSS
changed the title
|
LGTM, just needs the git url removing from the |
|
Closed in favor of ipfs/js-ipfs#2630. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new Big()cannot be applied to non-numericstringvariables, which can be the case whenhumanoption istrue.E.g.:
10GBThis PR fixes that problem.