This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
refactor: return peer ids as strings #1226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
alanshaw
approved these changes
Jan 27, 2020
|
Please add BREAKING CHANGE message. |
alanshaw
suggested changes
Jan 29, 2020
alanshaw
approved these changes
Jan 29, 2020
alanshaw
pushed a commit
to ipfs/js-ipfs
that referenced
this pull request
Feb 3, 2020
Also updates all examples to use the new API. Depends on: - [x] ipfs-inactive/interface-js-ipfs-core#581 - [x] ipfs-inactive/js-ipfs-http-client#1226 - [x] libp2p/js-libp2p#545 BREAKING CHANGE: Where `PeerID`s were previously [CID](https://www.npmjs.com/package/cids)s, now they are Strings - `ipfs.bitswap.stat().peers[n]` is now a String (was a CID) - `ipfs.dht.findPeer().id` is now a String (was a CID) - `ipfs.dht.findProvs()[n].id` is now a String (was a CID) - `ipfs.dht.provide()[n].id` is now a String (was a CID) - `ipfs.dht.put()[n].id` is now a String (was a CID) - `ipfs.dht.query()[n].id` is now a String (was a CID) - `ipfs.id().id` is now a String (was a CID) - `ipfs.id().addresses[n]` are now [Multiaddr](https://www.npmjs.com/package/multiaddr)s (were Strings)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
Where
PeerIDs were previously CIDs, now they are Stringsipfs.bitswap.stat().peers[n]is now a String (was a CID)ipfs.dht.findPeer().idis now a String (was a CID)ipfs.dht.findProvs()[n].idis now a String (was a CID)ipfs.dht.provide()[n].idis now a String (was a CID)ipfs.dht.put()[n].idis now a String (was a CID)ipfs.dht.query()[n].idis now a String (was a CID)ipfs.id().idis now a String (was a CID)ipfs.id().addresses[n]are now Multiaddrs (were Strings)Depends on: