-
Notifications
You must be signed in to change notification settings - Fork 299
Conversation
Pulling discussion from #623 (comment) @richardschneider mind opening a PR on js-ipfs-api?
We can have a flag that disables this test for Windows, it's ok.
Do you know what it was trying to dial to?
Sounds like this failed due to the previous dial fail
Increase the timeout?
Reported here #408
Weird, which ones? |
There are a few slashes |
@thisconnect Thanks. I plan to work on this code today. There are two issues:
|
On my local windows I'm getting ECONNREFUSED in https://github.com/ipfs/js-ipfs-api/blob/master/test/ipfs-factory/client.js It is trying to talk to localhost:55155 |
Solved the port 55155 issue. I was using |
@diasdavid I have made the minor changes to get this running on Windows. All the red lights have nothing to do with Windows and are pre-existing problems. |
Code: 'n/a', | ||
Message: err | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
it('skip these on Windows') | ||
return | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
The code can NOT handle x-stream-error correctly. See request-api
|
Use .emit('error', err)
6749d76
to
72aec49
Compare
See the discussion at #623