Wrap with dir

[daviddias]

from @wraithgar. just adding latest interface-ipfs-core

[daviddias]

@wraithgar seems that tests on wrap-with-directory are not passing here:

[wraithgar]

That test can't pass without the code in ipfs/js-ipfs#1290

[daviddias]

@wraithgar the js-ipfs-api runs its tests against go-ipfs. It doesn't use js-ipfs at all. It means that the client library is not interacting with go-ipfs properly which might mean there is some mismatch on how the http endpoint in js-ipfs is working from go-ipfs.

[wraithgar]

Ah ok I see. The test that's failing is the new one added in interface-ipfs-core which passes the new wrapWithDirectory parameter. So a go equivalent to that js-ipfs PR needs to exist first then right?

[daviddias]

This feature already exists on go-ipfs, it seems that the param for the endpoint was just not implemented in the same way.

See also the http-api docs https://ipfs.io/docs/api/#apiv0add

[daviddias]

@wraithgar this is currently blocking me from release js-ipfs-api given that interface-ipfs-core shipped with the test before this was complete (next time we need to run all the tests and make sure it all passes).

I'm just going to tackle it quick to unblock other work.

[daviddias]

it turned out that the test was the thing incorrect ipfs-inactive/interface-js-ipfs-core@a97c087