This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
fix: make pubsub.unsubscribe async and alter pubsub.subscribe signature #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: pubsub.unsubscribe is now async and argument order for pubsub.subscribe has changed License: MIT Signed-off-by: Alan Shaw <alan@tableflip.io>
ghost
assigned
This was referenced May 9, 2018
alanshaw
changed the title
daviddias
suggested changes
May 11, 2018
daviddias
approved these changes
May 12, 2018
|
Windows tests are having a hard time. Being fixed at #756 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on: ipfs-inactive/interface-js-ipfs-core#260