-
Notifications
You must be signed in to change notification settings - Fork 298
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@filips123 I wasn't aware there were modules in the dependencies that weren't Node.js 8 compatible yet - have you encountered issues?
Travis CI test of my package which has this package as a dependency will fail. Some of I didn't test this with I would be great if Node.js 8 would be supported (if possible) because some still use it. |
Ah yes, This problem will be resolved by #915. Lets merge this for now and we can revert after #915 is merged. |
CI failure is unrelated. |
Ok, but don't forget to fix #926 which added Node.js 10 requirement to README. |
@alanshaw is there anything I can help with bringing engine back to Node 8? It looks like the related PRs have already been merged, and I assume the offending library was taken out. |
@andremedeiros if you can do the work to verify the library is compatible with Node.js 8 and send a PR that would be great! |
See PR #996. |
Readme says that minimum Node.js version is 10. This is true because of some dependencies which also require version 10. However, in
package.json
file, minimum version is 8. This is incorrect, so I'm fixing this now.